Fix deadlock when stream is not consumed#229
Merged
dmcgowan merged 3 commits intocontainerd:mainfrom May 5, 2026
Merged
Conversation
dmcgowan
force-pushed
the
fix-recv-deadlock
branch
from
54d6191 to
f6cfbd8
Compare
dmcgowan
force-pushed
the
fix-recv-deadlock
branch
from
f6cfbd8 to
cf2d2f7
Compare
| return nil | ||
| case <-s.ctx.Done(): | ||
| return s.ctx.Err() | ||
| case <-time.After(time.Second): |
| return nil | ||
| case <-ctx.Done(): | ||
| return ctx.Err() | ||
| case <-time.After(time.Second): |
austinvazquez
approved these changes
May 1, 2026
Signed-off-by: Derek McGowan <[email protected]>
Return error if stream backs up and does not get consumed to prevent head of line blocking on the connection deadlocking all streams. Signed-off-by: Derek McGowan <[email protected]>
In go 1.23, when a timer is abandoned it is immediately available for GC. In prior versions, it was only available for GC after the timer fired. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
fix-recv-deadlock
branch
from
3b6123e to
cc8699e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return error if stream backs up and does not get consumed to prevent head of line blocking on the connection deadlocking all streams.
This currently shows up if a client creates a stream and stops calling recv message before the receiving the close stream message.